Skip to content

decoders.status() inserts None into Status object dictionary #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gregoryng wants to merge 1 commit into
base: master
Choose a base branch
from
Open

decoders.status() inserts None into Status object dictionary #305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions obd/decoders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,18 +299,24 @@ def status(messages):

# load the 3 base tests that are always present
for i, name in enumerate(BASE_TESTS[::-1]):
if name is None:
continue # filter out None/reserved tests
t = StatusTest(name, bits[13 + i], not bits[9 + i])
output.__dict__[name] = t

# different tests for different ignition types
if bits[12]: # compression
for i, name in enumerate(COMPRESSION_TESTS[::-1]): # reverse to correct for bit vs. indexing order
if name is None:
continue # filter out None/reserved tests
t = StatusTest(name, bits[(2 * 8) + i],
not bits[(3 * 8) + i])
output.__dict__[name] = t

else: # spark
for i, name in enumerate(SPARK_TESTS[::-1]): # reverse to correct for bit vs. indexing order
if name is None:
continue # filter out None/reserved tests
t = StatusTest(name, bits[(2 * 8) + i],
not bits[(3 * 8) + i])
output.__dict__[name] = t
Expand Down