feat: implement support for AWS Secrets Manager (alternative)#7
Open
jaulz wants to merge 4 commits intobrefphp:mainfrom
Open
feat: implement support for AWS Secrets Manager (alternative)#7jaulz wants to merge 4 commits intobrefphp:mainfrom
jaulz wants to merge 4 commits intobrefphp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried the existing PR #4 but I think it's way too opinionated about the format of secrets since it expects every secret to be a JSON. Also, it magically sets environment variables from the actual content of the secret. This is an alternative approach which simply writes the value of a secret to the environment variable. Parsing values from JSON might be a different story for a new PR. What do you think?