Conversation
|
I don't understand what this is about honestly.
But the diff still throws an exception, so I'm not sure what you mean. How are things different with that PR? What can you do that you couldn't do before? |
|
Actually, this is something I stumbled across when implementing brefphp/secrets-loader#4. In my opinion Bref should only check (but not prevent) loading of secrets via secrets manager. Currently, this package needs to be kept in sync with secrets loader because I didn't want to remove the original check to keep the existing behaviour so I kept the exception. |
|
Closing to clean up the issue tracker, that's not something I plan on merging right now. Let's reopen the discussion if needed. |
Right now, the logic whether the secrets loader will be used or not is implemented here in the first place. However, I think it should only be used to output a warning. That makes it easier to patch the secrets loader and for example use this proposed change: brefphp/secrets-loader#4