Add classifier support#154
Merged
Stephen Belanger (Qard) merged 5 commits intomainfrom May 8, 2026
Merged
Conversation
Stephen Belanger (Qard)
requested review from
Matt Perpick (clutchski) and
David Elner (delner)
Contributor
|
Can you add an |
Contributor
Author
|
Yep, added an example now. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… via helper Reverts the blanket `kwargs[:scorers] ||= [...]` added in d80d83c. Each test that actually runs an eval now explicitly passes `scorers: [noop_scorer]` where needed. Tests that only exercise validation paths (400/404) are unaffected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Abhijeet Prasad (AbhiPrasad)
approved these changes
May 5, 2026
Mirror the scorer error pattern by pushing classifier failures onto the errors queue, so they appear in result.errors (and result.success? is false) in addition to being recorded in span metadata. Addresses PR #154 review feedback.
Abhijeet Prasad (AbhiPrasad)
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for classifiers. It tries to align as much as possible with how scorers are implemented currently.