WIP: [codex] Add eval completion webhook support#405
Draft
Curtis Galione (cjgalione) wants to merge 2 commits intomainfrom
Draft
WIP: [codex] Add eval completion webhook support#405Curtis Galione (cjgalione) wants to merge 2 commits intomainfrom
Curtis Galione (cjgalione) wants to merge 2 commits intomainfrom
Conversation
The Braintrust Playground sends x-bt-use-gateway when gateway routing is enabled. The api-ts CORS config already allows it, but the Python devserver's ALLOWED_HEADERS list was missing it, causing browsers to block preflight requests to remote eval servers with a CORS error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an eval completion callback and devserver completion webhook support for Python evals.
Changes
on_completetoEvalandEvalAsync, called after eval completion and flush.on_complete_webhookparsing and devserver dispatch.Validation
Not run locally in this cleanup pass; preserving WIP before machine wipe.