Add backoff to summary fetch retries#1965
Open
Aaron (btaaron) wants to merge 3 commits intomainfrom
Open
Conversation
Aaron (btaaron)
changed the title
Aaron (btaaron)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds exponential backoff between existing JS SDK
get_jsonretries to help post runexperiment.summarize()calls to/experiment-comparison2, where immediate retries can repeat during the same transient 504/timeout window. Keeps existing retry count and only spaces out retries for callers already opting intoget_jsonretriesTest Plan
pnpm run buildpnpm exec vitest run src/logger.test.tspnpm exec vitest run tests/auto-instrumentations/loader-hook.test.tspnpm run testpnpm run check:typingsCI note
integration-tests/e2eande2e-canaryare failing on the Copilot/canary e2e suite, which is also failing onmain; JS checks for this PR are green