feat: Add @openai/codex-sdk instrumentation#1945
Open
Luca Forstner (lforst) wants to merge 9 commits intomainfrom
Open
feat: Add @openai/codex-sdk instrumentation#1945Luca Forstner (lforst) wants to merge 9 commits intomainfrom
@openai/codex-sdk instrumentation#1945Luca Forstner (lforst) wants to merge 9 commits intomainfrom
Conversation
Abhijeet Prasad (AbhiPrasad)
previously approved these changes
May 8, 2026
Comment on lines
+36
to
+37
| openaiCodex?: boolean; | ||
| codex?: boolean; |
There was a problem hiding this comment.
why do we have both? Feels confusing to me.
Comment on lines
+838
to
+842
| metrics.tokens = | ||
| (metrics.prompt_tokens ?? 0) + | ||
| (metrics.completion_tokens ?? 0) + | ||
| (metrics.prompt_cached_tokens ?? 0) + | ||
| (metrics.completion_reasoning_tokens ?? 0); |
There was a problem hiding this comment.
can we add a test to make sure this is not double counting tokens? Always get a bit scared at logic like this.
| return; | ||
| } | ||
| states.delete(event); | ||
| void finalizeCompletedRun(state, event.result); |
There was a problem hiding this comment.
should we not await on these?
| arguments: args, | ||
| operation: "run", | ||
| thread: target, | ||
| } as never, |
Abhijeet Prasad (AbhiPrasad)
dismissed
their stale review
oops approved by accident
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1902