Add mastra auto-instrumentation#1901
Open
Stephen Belanger (Qard) wants to merge 8 commits intomainfrom
Open
Conversation
Luca Forstner (lforst)
approved these changes
Apr 24, 2026
Member
Luca Forstner (lforst)
left a comment
There was a problem hiding this comment.
Can we also add the mastra e2e test scenario to the ci summary?
37f8aaa to
43c826c
Compare
443f70c to
8d58469
Compare
…a directly to interface Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…pes for groq/mastra groq and mastra are runtime-only defaults not user-configurable via InstrumentationConfig, so they don't belong in the public interface. Widen getDefaultConfig() and readEnvConfig() return types to Record<string, boolean> so groq/mastra can be included as defaults without adding them to the public InstrumentationConfig interface. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… unused types - Remove mastra from BraintrustPluginConfig inline type (api-compat flags any change to the inline type string; use getIntegrationConfig dynamic lookup instead, same pattern as groq in other integration PRs) - Remove unused IntegrationName/IntegrationMap type aliases (no longer referenced after widening getDefaultConfig/readEnvConfig return types) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
c01e4fd to
ffcc4ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #1890
Summary
Testing
pnpm --dir js exec vitest run src/auto-instrumentations/configs/mastra.test.ts src/instrumentation/plugins/mastra-plugin.test.ts src/instrumentation/registry.test.tspnpm run test:e2e -- mastra-instrumentationNotes
pnpm --dir js test -- mastraandpnpm --dir js test -- auto-instrumentationsstill hit unrelated existing network-dependent failures insrc/framework.test.tsandsrc/logger-misc.test.tspnpm run formattingstill reports pre-existing unformatted fixture files underjs/tests/auto-instrumentations/fixtures/test-files/