trace scoring#90
Open
Andrew Kent (realark) wants to merge 1 commit intomainfrom
Open
Conversation
Andrew Kent (realark)
force-pushed
the
ark/trace-scoring
branch
12 times, most recently
from
f1fbd7c to
c49a985
Compare
Andrew Kent (realark)
changed the base branch from
main
to
ark/api-client-codegen
Andrew Kent (realark)
force-pushed
the
ark/trace-scoring
branch
9 times, most recently
from
ee4746f to
68f6ec1
Compare
Andrew Kent (realark)
force-pushed
the
ark/api-client-codegen
branch
from
299c838 to
7511097
Compare
Andrew Kent (realark)
force-pushed
the
ark/trace-scoring
branch
4 times, most recently
from
5b7070c to
8e0dd94
Compare
| int lastInputLength = 0; | ||
|
|
||
| for (var span : sorted) { | ||
| // Extract new input messages (only those beyond what prior spans already contributed) |
There was a problem hiding this comment.
won't this break if there are independent llm spans happening? Like with subagents? Or am I thinking about this incorrectly?
Collaborator
Author
There was a problem hiding this comment.
yeah that would break. I updated the logic to do a proper tree traversal + dedup. Did another manual test against an opencode trace with subagents: https://www.braintrust.dev/app/braintrustdata.com/p/andrew-misc/logs?tvt=trace&r=e6ca417d-e5e4-45b8-8e5f-90fb1e4f703e&s=e6ca417d-e5e4-45b8-8e5f-90fb1e4f703e
Andrew Kent (realark)
force-pushed
the
ark/trace-scoring
branch
from
8e0dd94 to
0d84481
Compare
Andrew Kent (realark)
force-pushed
the
ark/trace-scoring
branch
from
0d84481 to
2e43936
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.