feat(release-notes): add explicit Node setup and replace awk with TypeScript#14
Open
GoogilyBoogily wants to merge 1 commit into
Open
feat(release-notes): add explicit Node setup and replace awk with TypeScript#14GoogilyBoogily wants to merge 1 commit into
GoogilyBoogily wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes the release-notes composite action more self-contained by adding Node setup and replacing inline shell parsing of CHANGELOG.md with the existing TypeScript release-notes extractor.
Changes:
- Adds an explicit
actions/setup-node@v6step to the release-notes action. - Replaces the previous
awk/heredoc extraction withnode dist/extract-release-notes.js.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| awk '/^## / { if (p) exit; p=1 } p' CHANGELOG.md | sed '1d' | ||
| echo EOF | ||
| } >> "$GITHUB_OUTPUT" | ||
| run: node '${{ github.action_path }}/../../dist/extract-release-notes.js' |
GoogilyBoogily
force-pushed
the
feat/version-bump-ts
branch
from
c6a77f4 to
1c72cb4
Compare
GoogilyBoogily
force-pushed
the
feat/release-notes
branch
from
8257bf0 to
6d83903
Compare
GoogilyBoogily
force-pushed
the
feat/release-notes
branch
from
6d83903 to
703a04d
Compare
GoogilyBoogily
force-pushed
the
feat/version-bump-ts
branch
from
1c72cb4 to
4aeba69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes to
actions/release-notes/action.yml:Add explicit
actions/setup-node@v6step — the action previously assumed Node.js was already set up by a prior action in the same job, creating a fragile implicit dependency. Now self-contained.Replace awk/heredoc with TypeScript — the CHANGELOG parsing step used a multi-line awk expression writing to a heredoc
GITHUB_OUTPUT. Replaced withnode dist/extract-release-notes.js(from thefeat/git-utilsPR).Test plan
publish.ymlwithdry-run: true— release notes are extracted and logged, no GitHub release createdvalidate-scriptsCI passes