feat: add TypeScript build infrastructure#10
Open
GoogilyBoogily wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces TypeScript build infrastructure for the shared GitHub Actions repository so future action scripts can move from bash into typed source files compiled into committed dist/ output.
Changes:
- Adds npm/TypeScript project configuration and Node version pinning.
- Adds a shared
getRequiredEnv()helper with compiled output indist/. - Adds CI validation to build TypeScript and verify
dist/is up to date.
Reviewed changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/validate-scripts.yml |
Adds self-CI to install dependencies, build scripts, and verify committed dist/. |
.gitignore |
Ignores local node_modules/. |
.nvmrc |
Pins the repo’s Node version to 24. |
dist/utils.js |
Adds compiled CommonJS output for the utility helper. |
package-lock.json |
Locks the newly added npm dependency tree. |
package.json |
Defines scripts and action-related TypeScript dependencies. |
src/utils.ts |
Adds a shared required-environment-variable helper. |
tsconfig.json |
Configures strict TypeScript compilation to dist/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8e4cc87 to
9a0ec15
Compare
9a0ec15 to
f6ec24f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets up TypeScript compilation for GitHub Action scripts. Complex bash logic in later PRs will be extracted into typed, testable
.tsfiles compiled todist/.package.jsonwith@actions/core,@actions/exec,@actions/githubdepstsconfig.jsontargeting CommonJS/ES2022,strict: true.nvmrcpinned to Node 24src/utils.ts: sharedgetRequiredEnv()helper used by all scriptsdist/committed to repo (required — consumers checkout and runnode dist/script.jsdirectly).github/workflows/validate-scripts.yml: self-CI that builds and enforcesdist/stays in sync viagit diff --exit-code dist/Test plan
npm ci && npm run buildpasses locallygit diff --exit-code dist/is clean after buildvalidate-scriptsworkflow passes on this PR