Skip to content

Conversation

@nirg122
Copy link

@nirg122 nirg122 commented Aug 17, 2022

fixes logging out crashing the app with continuous error of "cannot get property of null (token)" in newer version of react.

fixes logging out crashing the app with continuous error of "cannot get property of null (token)" in newer version of react.
Copy link

@im-ghost im-ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you get the goals after the page alr redirected to a login page

@nirg122
Copy link
Author

nirg122 commented Oct 2, 2022

Why would you get the goals after the page alr redirected to a login page

I think you read the code wrong.
I redirect only if the user is not logged in, else (if the user is logged in), I'm getting all the goals.

Copy link

@im-ghost im-ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on the other commit,my bad.

Copy link

@fisayo-dmg fisayo-dmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, noticed this bug and was about to suggest this same change.

Copy link

@Lukeos11 Lukeos11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the same error this fixes it

Copy link

@ziaulkadri ziaulkadri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves mine error too

Copy link

@MadManMcIvor MadManMcIvor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent so long trying to figure out what was going on. This solved it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants