Make recipe viewer slots more generic and fix some emi stuff#11
Open
gustovafing wants to merge 11 commits intobrachy84:recipeviewersfrom
Open
Make recipe viewer slots more generic and fix some emi stuff#11gustovafing wants to merge 11 commits intobrachy84:recipeviewersfrom
gustovafing wants to merge 11 commits intobrachy84:recipeviewersfrom
Conversation
screret
requested changes
May 8, 2026
| } | ||
|
|
||
| private void rebuildEmiSlot() { | ||
| if (value instanceof ItemEntryList itemEntryList) { |
Collaborator
There was a problem hiding this comment.
Why is this hardcoded to items and fluids?
screret
reviewed
May 10, 2026
| return new EmiRecipeViewerSlot(); | ||
| } else if (ModularUI.Mods.JEI.isLoaded()) { | ||
| return new JeiRecipeViewerSlot(); | ||
| } else { |
Collaborator
There was a problem hiding this comment.
still no explicit REI check?
Also, REI overrides JEI completely if it's loaded but still "loads" "jei" if the plugin compat addon is installed, so the check order should be EMI -> REI -> JEI.
| renderer.setSimulate(true); | ||
| renderer.draw(null, this.key); | ||
| // Don't update the key here, otherwise an infinite loop of checkComponentUpdated -> simulate -> checkComponentUpdated occurs | ||
| renderer.draw(null, key); |
Collaborator
There was a problem hiding this comment.
Suggested change
| renderer.draw(null, key); | |
| renderer.draw(null, this.key); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
RecipeViewerSlotWidgetclass which represents a recipe viewer slot.RecipeViewerSlotWidget.create()creates the appropriate subclass ofRecipeViewerSlotWidgetfor the currently loaded recipe viewer.Also allows the text widget to get its component from a supplier, to allow for dynamic components to be used as text widgets.