[codex] Export WebGL figure initializer#29
Draft
maartenbreddels wants to merge 1 commit intobqplot:masterfrom
Draft
[codex] Export WebGL figure initializer#29maartenbreddels wants to merge 1 commit intobqplot:masterfrom
maartenbreddels wants to merge 1 commit intobqplot:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small support PR for downstream bqplot WebGL widget packages.
bqplot 0.13 moved the shared WebGL figure renderer setup into bqplot-gl. Downstream packages such as bqplot-image-gl need to initialize that shared renderer when they render their own WebGL marks, but the initializer currently lives in an internal module and is not exported from the package entry point.
This PR exports the existing WebGL figure initialization utilities from the frontend entry point so downstream widget bundles can call the same setup path as bqplot-gl marks. It also includes GLSL shader sources in the npm package files list. Without those shader files, downstream package builds that install bqplot-gl from npm can fail while resolving raw-loader imports such as ../shaders/scales.glsl.
Validation:
The nbextension build completed with existing source-map and bundle-size warnings, but no errors. This PR is opened as a draft because we want to demonstrate the downstream bqplot-image-gl fix against this branch before marking it ready.