Clean up sizes/sizegroup: deduplicate sizes + cross-reference table

[Copilot]

Implements the size/sizegroup database cleanup.

Migration 1 – 20260421120000_CreateSizesSizegroupTable

1. Creates the sizes_sizegroup cross-reference table (many-to-many between sizes and sizegroup).
2. Populates it from sizes.sizegroup_id for every size currently in the table — including the 66 duplicates that Migration 2 will later remove (so no "extra memberships" block is needed).
3. Drops the now-redundant sizegroup_id and seq columns from sizes.

The down() method restores sizegroup_id/seq, re-populates them from sizes_sizegroup, and drops the cross-reference table.

Migration 2 – 20260421130000_DeduplicateSizes

Removes 66 duplicate size rows from the sizes table (keeping the entry with the smallest ID for each label). Before deleting the duplicates, all foreign-key references are redirected to the surviving ID:

Table	Column(s) updated
stock	size_id
shipment_detail	source_size_id, target_size_id
history	from_int, to_int (for tablename='stock', changes='size_id')
itemsout	size_id
distro_events_packing_list_entries	size_id
distro_events_tracking_logs	size_id
distro_events_unboxed_item_collections	size_id

sizes_sizegroup rows for duplicate sizes are then remapped to their canonical ID via INSERT IGNORE (so canonical sizes inherit all sizegroup memberships from their duplicates). The ON DELETE CASCADE on fk_ss_size_id removes the old duplicate rows when the duplicate sizes rows are deleted.

The down() method re-inserts the 66 deleted sizes rows (id + label only, since sizegroup_id/seq are managed by Migration 1) and their corresponding sizes_sizegroup entries, then removes the inherited sizegroup memberships from the canonical sizes (partial rollback; FK remappings cannot be reconstructed).

Migration 3 – 20260421140000_DropAuditColumnsFromSizes

Removes the unused audit columns (created, created_by, modified, modified_by) from the sizes table. These columns are all NULL in every known environment and are not referenced by any application code. FK constraints and indexes on created_by / modified_by are dropped first.

The down() method restores the columns, indexes, and FK constraints referencing cms_users.

Migration 4 – 20260421150000_FixSizesData

Cleans up data inconsistencies in the sizes_sizegroup table:

1. Sizegroup 1 (XS, S, M, L, XL, XXL): corrects seq values to XS=1, S=2, M=3, L=4, XL=5, XXL=6, Mixed=999.
2. Sizegroup 23 (Children by year 2-3 to 14-15): corrects seq values to 2-3y=200, 4-5y=201, 6-7y=202, 8-9y=203, 10-11y=204, 12-13y=205, 14-15y=206, All ages=207, Mixed=999.
3. Sizegroups 17, 18, 22, 25: adds the "All ages" size (id=97) to each sizegroup.

The down() method removes the added "All ages" entries and restores the original seq values.

Migration 5 – 20260421160000_RemoveSizegroup20

Removes the now-superseded sizegroup 20 ("Children by month (2-5)"), replacing it with sizegroup 17 ("Children by year (2-5, 6-10, 11-15)"):

1. Reassigns any products rows referencing sizegroup_id=20 to sizegroup_id=17.
2. Deletes sizes_sizegroup rows for sizegroup 20.
3. Deletes sizegroup ID 20 from the sizegroup table.

The down() method re-inserts sizegroup 20 and its sizes_sizegroup entries (product reassignments are not reversed — partial rollback).

Code changes

File	Change
include/container-stock.php	Replaced implicit cross join with explicit INNER JOIN sizes_sizegroup … INNER JOIN sizes
library/ajax/getsizes.php	Updated size-lookup query to JOIN via sizes_sizegroup
include/stock_edit.php	Updated size-dropdown query to JOIN via sizes_sizegroup

Verification

• Migrations run cleanly on the dev database
• vendor/bin/parallel-lint – no errors
• php-cs-fixer – 0 files to fix (excluding auto-generated templates)
• No duplicate size labels remain
• All sizegroup memberships preserved: size labels per sizegroup are identical before and after Migration 2
• After all five migrations, the sizes table contains only id and label
• Sizegroups 1 and 23 have correct sequential seq values; sizegroups 17, 18, 22, and 25 include "All ages"
• Sizegroup 20 is removed; products formerly assigned to it are reassigned to sizegroup 17

[pylipp]

@copilot revert any (formatting) changes in files that are NOT in db/migrations and NOT container-stock.php

[pylipp]

https://trello.com/c/Ld7cSa0s

[Copilot]

@copilot revert any (formatting) changes in files that are NOT in db/migrations and NOT container-stock.php

Done in b060b78 — reverted formatting changes in all files outside db/migrations/ and include/container-stock.php.

[Copilot]

Pull request overview

Refactors the app’s size/sizegroup data model by removing duplicate sizes rows and moving from a 1→many (sizes.sizegroup_id) relationship to a many→many relationship via a new sizes_sizegroup cross-reference table, updating stockroom querying accordingly.

Changes:

• Add a migration to deduplicate sizes labels by remapping foreign keys and deleting duplicate rows.
• Add a migration to create/populate sizes_sizegroup, then drop sizes.sizegroup_id and sizes.seq.
• Update the stockroom listing query to join sizes via sizes_sizegroup instead of sizes.sizegroup_id.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
include/container-stock.php	Switches sizegroup matching logic to use the new sizes_sizegroup join.
db/migrations/20260421120000_deduplicate_sizes.php	Remaps references to removed size IDs and deletes duplicate sizes rows.
db/migrations/20260421130000_create_sizes_sizegroup_table.php	Introduces sizes_sizegroup, migrates memberships, and drops legacy sizes columns.

[pylipp]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

Done in 18aab4f. Applied all three review changes:

1. Migration 1 (deduplicate_sizes): Added remapping of itemsout and all distro_events_* tables that have a size_id column (via INFORMATION_SCHEMA) before the DELETE, preventing FK RESTRICT violations.

2. include/sizes.php and library/ajax/getsizes.php: Updated all queries to JOIN via sizes_sizegroup and order by ss.seq instead of the removed sizes.sizegroup_id/sizes.seq columns. The re-ordering initialization in sizes.php now updates sizes_sizegroup.seq, and the list display uses GROUP_CONCAT for sizes belonging to multiple sizegroups.

3. include/stock_edit.php and include/sizes_edit.php: Also updated for the removed columns — stock_edit.php uses a JOIN on sizes_sizegroup for the size dropdown, and sizes_edit.php has sizegroup_id removed from savekeys and the form (the column no longer exists on sizes).

[HaGuesto]

functional review continued

Run rollback

• size and sizegroup tables are the same as before

Run first and second migration

• number of sizes reduced from 179 to 113 as expected.
• sizes_sizegroup table lost one enty? There seemed to be a duplicate entry of All Ages in one sizegroup.
• history snapshot of 10 changes was correct
• stock snapshot of 10 changes was correct
• shipment_detail snapshot of 10 changes was correct
  @pylipp I found a shipment detail with source_size_id = NULL. does that make sense?

Run rollback of second migration

works

[HaGuesto]

ACTION: @HaGuesto to functional test query updates.
ACTION: @HaGuesto to test if removed "All ages" size was removed correctly.
ACTION: @HaGuesto to send @pylipp table of seq changes and 'All ages' sizes to add
ACTION: @pylipp to ask @aerinsol regarding removing "mixed" size option from "one size"

[HaGuesto]

ACTION: @HaGuesto to functional test query updates.

DONE. passed

ACTION: @HaGuesto to test if removed "All ages" size was removed correctly.

Done. Yes.

ACTION: @HaGuesto to send @pylipp table of seq changes and 'All ages' sizes to add

Done

[pylipp]

@copilot I need another migration to clean-up inconsistencies in the sizes data. It should run fourth.

• update seq for sizes of sizegroup 1. It should be 1-6 for XS, S, ..., XXL and 999 for Mixed
• update seq for sizes of sizegroup 23. It should be 200-206 for 2-3y, 4-5y, ..., 14-15y, 207 for All ages and 999 for Mixed
• add "All ages" size for sizegroups 17, 18, 22, 25
• implement the up() and the corresponding down migration

[Copilot]

@copilot I need another migration to clean-up inconsistencies in the sizes data. It should run fourth.

• update seq for sizes of sizegroup 1. It should be 1-6 for XS, S, ..., XXL an...

Done in 04d0dfc — added migration 20260421150000_FixSizesData:

• Sizegroup 1: seq corrected to XS=1, S=2, M=3, L=4, XL=5, XXL=6, Mixed=999
• Sizegroup 23: seq corrected to 2-3y=200, 4-5y=201, 6-7y=202, 8-9y=203, 10-11y=204, 12-13y=205, 14-15y=206, All ages=207, Mixed=999
• Sizegroups 17, 18, 22, 25: "All ages" (id=97) added with seq 13, 22, 182, 246 respectively

down() removes the added "All ages" entries and restores the original seq values. Both up() and down() verified on the dev database.

[pylipp]

@copilot I need another migration to remove the sizegroup 20 ("Children by year (2-5)"). It should run last.
In the up-function:

• replace sizegroup 20 by 17 in the products table
• remove rows with sizegroup 20 from the sizes_sizegroup table
• remove ID 20 from the sizegroup table
  In the down function:
• add ID 20 back to sizegroup table
• add rows back to sizes_sizegroup table

[Copilot]

@copilot I need another migration to remove the sizegroup 20 ("Children by year (2-5)"). It should run last.
In the up-function:

• replace sizegroup 20 by 17 in the products table
  ...

Done in 7067a15 — added migration 20260421160000_RemoveSizegroup20:

• up(): reassigns products with sizegroup_id=20 to sizegroup_id=17, deletes sizes_sizegroup rows for sizegroup 20 (sizes 116 "2-5 years" and 52 "Mixed"), then deletes the sizegroup 20 row.
• down(): re-inserts the sizegroup 20 row and its two sizes_sizegroup entries (product reassignments are not reversed — partial rollback).

Verified both up() and down() on the dev database.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.