feat: Unify secure storage backend across platforms#647
Open
arjankowski wants to merge 3 commits intomainfrom
Open
feat: Unify secure storage backend across platforms#647arjankowski wants to merge 3 commits intomainfrom
arjankowski wants to merge 3 commits intomainfrom
Conversation
arjankowski
force-pushed
the
secure-storage-wrapper
branch
from
01770fb to
57c06a1
Compare
Pull Request Test Coverage Report for Build 23089457267Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates how the CLI reads and writes secure data so we can avoid repeated macOS Keychain prompts after upgrades.
The key issue is that on macOS, Keychain access control is tied to application identity and signature. When access goes through
keytar, it is associated with the currentnode/boxexecutable identity, and after signed build changes between versions macOS can treat that as a different app and ask for permission again. To make this stable, we now use thekeychainlibrary on macOS, which calls the system/usr/bin/securitybinary, so Keychain access is performed through a consistent process identity.This change is mainly needed to prevent those upgrade-time prompts and make access to existing environments and tokens reliable.