-
Notifications
You must be signed in to change notification settings - Fork 344
fix: expand TextInputWithCopyButton input to container width #4418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
src/components/text-input-with-copy-button/TextInputWithCopyButton.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/components/text-input-with-copy-button/TextInputWithCopyButton.scss`:
- Around line 12-14: The .text-input-tooltip-wrapper rule uses width: stretch
which is experimental; update the stylesheet to provide a compatible fallback by
adding width: 100% before width: stretch and, if desired, include
vendor-prefixed variants (e.g., -webkit-stretch and -moz-stretch) after the
fallback to preserve experimental behavior in supporting browsers; ensure the
width: 100% line appears before the stretch declarations so non-supporting
browsers use the reliable fallback.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/components/text-input-with-copy-button/TextInputWithCopyButton.scss
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: lint_test_build
- GitHub Check: Summary
🔇 Additional comments (1)
src/components/text-input-with-copy-button/TextInputWithCopyButton.scss (1)
36-38: LGTM!Formatting change for linting compliance. No functional impact.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
src/components/text-input-with-copy-button/TextInputWithCopyButton.scss
Outdated
Show resolved
Hide resolved
dc49df2 to
adc0e5a
Compare
src/components/text-input-with-copy-button/TextInputWithCopyButton.js
Outdated
Show resolved
Hide resolved
src/components/text-input-with-copy-button/TextInputWithCopyButton.js
Outdated
Show resolved
Hide resolved
Merge Queue Status✅ The pull request has been merged at 99acdef This pull request spent 9 minutes 41 seconds in the queue, including 9 minutes 32 seconds running CI. Required conditions to merge
|
User reported an issue with resizing TextInputCopyButton -- the input would not expand to match the copy button if they set the width of the container to 100%.
https://box.slack.com/archives/C09J7RM2UFR/p1768386832459429

Fixes it by adding
width: 100%to the Tooltip wrapper.Summary by CodeRabbit
New Features
Style
✏️ Tip: You can customize this high-level summary in your review settings.