-
Notifications
You must be signed in to change notification settings - Fork 345
fix(content-sharing): Shared link modal and collaborators #4360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(content-sharing): Shared link modal and collaborators #4360
Conversation
WalkthroughThe PR bumps Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant UI as ContentSharing UI
participant Hook as useSharingService
participant APIClient as API Client Factory
note right of Hook `#DFF6E0`: New behavior
UI->>Hook: request sharingService for item (file/folder)
Hook->>APIClient: getFileAPI(false) / getFolderAPI(false)
APIClient-->>Hook: file/folder API instance
Hook-->>UI: sharingService (uses provided API instance)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks. You may have to fix your CI before adding the pull request to the queue again. |
What
Testing
Summary by CodeRabbit