Skip to content

fix: Fix modernization hook for ContentSharing v2 #4339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Oct 15, 2025
Merged

fix: Fix modernization hook for ContentSharing v2 #4339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73467b6
fix: Fix modernization hook for ContentPickerV2
jfox-box Oct 15, 2025
516e0f4
fix: Align modernization story names
jfox-box Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/elements/content-explorer/stories/tests/ContentExplorer-visual.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const basic = {
},
};

export const Modernization = {
export const withModernization = {
args: {
enableModernizedComponents: true,
},
Expand Down
2 changes: 1 addition & 1 deletion src/elements/content-picker/stories/tests/ContentPicker-visual.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { DEFAULT_HOSTNAME_API } from '../../../../constants';

export const basic = {};

export const Modernization = {
export const withModernization = {
args: {
enableModernizedComponents: true,
},
Expand Down
2 changes: 1 addition & 1 deletion src/elements/content-preview/stories/tests/ContentPreview-visual.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const basic = {
},
};

export const Modernization = {
export const withModernization = {
args: {
enableModernizedComponents: true,
},
Expand Down
3 changes: 2 additions & 1 deletion src/elements/content-sharing/ContentSharingV2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import type { CollaborationRole, Collaborator, Item, SharedLink, User } from '@b
import API from '../../api';
import Internationalize from '../common/Internationalize';
import Providers from '../common/Providers';
import { withBlueprintModernization } from '../common/withBlueprintModernization';
import { fetchAvatars, fetchCollaborators, fetchCurrentUser, fetchItem } from './apis';
import { useSharingService } from './hooks/useSharingService';
import { convertCollabsResponse, convertItemResponse } from './utils';
Expand Down Expand Up @@ -177,4 +178,4 @@ function ContentSharingV2({
);
}

export default ContentSharingV2;
export default withBlueprintModernization(ContentSharingV2);
4 changes: 3 additions & 1 deletion src/elements/content-sharing/stories/tests/ContentSharingV2-visual.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import * as React from 'react';
import { expect, screen, userEvent, waitFor, within } from 'storybook/test';

import { Button } from '@box/blueprint-web';

import { TYPE_FILE } from '../../../../constants';
import {
mockAPIWithCollaborators,
Expand Down Expand Up @@ -69,7 +71,7 @@ export default {
title: 'Elements/ContentSharingV2/tests/visual-regression-tests',
component: ContentSharingV2,
args: {
children: <button>Open Unified Share Modal</button>,
children: <Button>Open Unified Share Modal</Button>,
itemType: TYPE_FILE,
itemID: global.FILE_ID,
},
Expand Down
2 changes: 1 addition & 1 deletion src/elements/content-sidebar/stories/tests/ContentSidebar-visual.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default {
},
};

export const Modernization = {
export const withModernization = {
args: {
enableModernizedComponents: true,
},
Expand Down
2 changes: 1 addition & 1 deletion src/elements/content-uploader/stories/tests/ContentUploader-visual.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const basic = {
},
};

export const Modernization = {
export const withModernization = {
args: {
enableModernizedComponents: true,
},
Expand Down