-
Notifications
You must be signed in to change notification settings - Fork 344
feat(content-sharing): Create ContentSharingV2 component #4282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8393705
feat: Create ContentSharingV2 component
reneshen0328 5794c3c
feat: Create ContentSharingV2 component
reneshen0328 2315617
fix: flow
reneshen0328 8f90da5
fix: remove not needed code
reneshen0328 eadbc19
fix: remove not needed code
reneshen0328 fa7cf77
fix: address comments
reneshen0328 572b55f
fix: disable snapshot
reneshen0328 2061142
Merge branch 'master' into feat-create-content-sharing-v2
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import * as React from 'react'; | ||
|
|
||
| import { UnifiedShareModal } from '@box/unified-share-modal'; | ||
|
|
||
| import Internationalize from '../common/Internationalize'; | ||
| import Providers from '../common/Providers'; | ||
|
|
||
| import type { ItemType, StringMap } from '../../common/types/core'; | ||
|
|
||
| export interface ContentSharingV2Props { | ||
| /** children - Children for the element to open the Unified Share Modal */ | ||
| children?: React.ReactElement; | ||
| /** itemID - Box file or folder ID */ | ||
| itemID: string; | ||
| /** itemType - "file" or "folder" */ | ||
| itemType: ItemType; | ||
| /** hasProviders - Whether the element has providers for USM already */ | ||
| hasProviders: boolean; | ||
| /** language - Language used for the element */ | ||
| language?: string; | ||
| /** messages - Localized strings used by the element */ | ||
| messages?: StringMap; | ||
| } | ||
|
|
||
| function ContentSharingV2({ children, itemID, itemType, hasProviders, language, messages }: ContentSharingV2Props) { | ||
| // Retrieve item from API later | ||
| const mockItem = { | ||
| id: itemID, | ||
| name: 'Box Development Guide.pdf', | ||
| type: itemType, | ||
| }; | ||
|
|
||
| return ( | ||
| <Internationalize language={language} messages={messages}> | ||
| <Providers hasProviders={hasProviders}> | ||
| <UnifiedShareModal item={mockItem}>{children}</UnifiedShareModal> | ||
| </Providers> | ||
| </Internationalize> | ||
| ); | ||
| } | ||
|
|
||
| export default ContentSharingV2; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
src/elements/content-sharing/stories/ContentSharingV2.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import * as React from 'react'; | ||
| import { TYPE_FILE, TYPE_FOLDER } from '../../../constants'; | ||
| import ContentSharingV2 from '../ContentSharingV2'; | ||
|
|
||
| export const basic = {}; | ||
|
|
||
| export default { | ||
| title: 'Elements/ContentSharingV2', | ||
| component: ContentSharingV2, | ||
| args: { | ||
| children: <button>Open Unified Share Modal</button>, | ||
| itemType: TYPE_FILE, | ||
| itemID: global.FILE_ID, | ||
| }, | ||
| argTypes: { | ||
| itemType: { | ||
| options: [TYPE_FILE, TYPE_FOLDER], | ||
| control: { type: 'select' }, | ||
| }, | ||
| }, | ||
| parameters: { | ||
| chromatic: { | ||
| disableSnapshot: true, | ||
| }, | ||
| }, | ||
| }; |
17 changes: 17 additions & 0 deletions
17
src/elements/content-sharing/stories/tests/ContentSharingV2-visual.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { TYPE_FILE } from '../../../../constants'; | ||
| import ContentSharingV2 from '../../ContentSharingV2'; | ||
|
|
||
| export const withModernization = { | ||
| args: { | ||
| enableModernizedComponents: true, | ||
| }, | ||
| }; | ||
|
|
||
| export default { | ||
| title: 'Elements/ContentSharingV2/tests/visual-regression-tests', | ||
| component: ContentSharingV2, | ||
| args: { | ||
| itemType: TYPE_FILE, | ||
| itemID: global.FILE_ID, | ||
| }, | ||
| }; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.