-
Notifications
You must be signed in to change notification settings - Fork 186
chore: Added notify-changelog workflow #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # A GitHub action that notifies the developer | ||
| # changelog repository of any new releases. | ||
|
|
||
| name: Notify changelog | ||
|
|
||
| on: | ||
| # Only trigger for a full release, | ||
| # ignoring pre-releases and drafts | ||
| release: | ||
| types: | ||
| - released | ||
|
|
||
| jobs: | ||
| notify: | ||
| # This job can run on the latest Ubuntu | ||
| # and it should not take more than 3 minutes | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 3 | ||
|
|
||
| steps: | ||
| - name: Notify changelog of new release | ||
| uses: peter-evans/repository-dispatch@v1 | ||
| with: | ||
| token: ${{ secrets.DISPATCH_ACCESS_TOKEN }} | ||
| repository: box/box-developer-changelog | ||
| event-type: new-release-note | ||
| client-payload: '{"ref": "${{ github.ref }}", "repository": "${{github.repository}}", "labels": "sdks,java", "repo_display_name": "Box Java SDK"}' | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Copilot Autofix
AI 3 months ago
The best fix is to explicitly restrict the GITHUB_TOKEN permissions at the earliest reasonable scope. In this workflow, that can be at the workflow level (root), or job level (
notify). Given there is only one job, placing it at the workflow level for clarity is the most future-proof for potential additional jobs. Since this workflow appears to notify an external repository using therepository-dispatchaction, onlycontents: readis required for most cases (access to the repository's contents). As the action is provided a personal access token via${{ secrets.DISPATCH_ACCESS_TOKEN }}and does not use the defaultGITHUB_TOKENfor dispatch, it likely needs no special write rights at all. Therefore, setpermissions: contents: readat the workflow root, granting the minimum access needed.name:line and beforeon:, in.github/workflows/notify-changelog.yml: