Skip to content

Conversation

@johnomotani
Copy link
Collaborator

When the next version of xBOUT is released, the theta dimension will change to being named y in xBOUT-loaded grid files. Then we will need to update scripts/hypnotoad_plot_grid_cells.py to be compatible with that change.

  • Updated doc/whats-new.md with a summary of the changes

@mikekryjak
Copy link
Collaborator

Where is that xBOUT change? I couldn't immediately see it on the repo. It's a welcome change but would break a lot on my end, so would be good to take a look.

@johnomotani
Copy link
Collaborator Author

Where is that xBOUT change? I couldn't immediately see it on the repo. It's a welcome change but would break a lot on my end, so would be good to take a look.

Only affects loading grid files, not normal output.
boutproject/xBOUT#307

@timothy-nunn
Copy link
Collaborator

timothy-nunn commented Jun 13, 2025

@johnomotani thanks for this, can confirm that this PR + #191 + v0.3.0 of boutdata fixes #189 and allows grids (which need to be re-created with these new software versions) to be plotted using hypnotoad-plot-grid-cells.

Is it maybe a good idea to add a test to hypnotoad-plot-grid-cells in this PR? E.g. running hypnotoad.scripts.hypnotoad_plot_grid_cells:main during one of the connected_doublenull_orthogonal cases?

@johnomotani
Copy link
Collaborator Author

Is it maybe a good idea to add a test to hypnotoad-plot-grid-cells in this PR?

hypnotoad-plot-grid-cells is tested in the 'utilities' job. We seem to have got to a point where there is sometimes a long time between PRs being made/merged into this repo. It might be useful to add a regular check (e.g. once per month) of master to catch these version incompatibility issues. I'll add that into #191 and we can see if it helps.

@johnomotani johnomotani force-pushed the fix-xbout-grid-loading branch from 5319950 to ae08894 Compare June 13, 2025 11:27
Updates due to changes in xBOUT.
@johnomotani johnomotani force-pushed the xbout-compatibility branch from c62d8d4 to a70c721 Compare June 13, 2025 11:29
Base automatically changed from fix-xbout-grid-loading to master June 13, 2025 13:39
@johnomotani johnomotani marked this pull request as ready for review August 21, 2025 16:25
@johnomotani
Copy link
Collaborator Author

Released a new xBOUT, so this should be ready to merge once it's updated. Maybe after #183?

@johnomotani johnomotani merged commit ae04a86 into master Aug 28, 2025
25 checks passed
@johnomotani johnomotani deleted the xbout-compatibility branch August 28, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants