SNES and PETSc solvers call MPI_Abort on exceptions #3252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch exceptions and call MPI_Abort rather than trying to continue. There is no way to recover and synchronise processors unless all processors threw an exception at the same point. If only one processor throws an exception then the others will wait indefinitely on the next MPI communication or collective operation.
Contributor
|
If the failures are to random transient NaNs, can we substitute them with an average of surrounding cells to prevent the failure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch exceptions and call MPI_Abort rather than trying to continue.
There is no way to recover and synchronise processors unless all processors threw an exception at the same point. If only one processor throws an exception then the others will wait indefinitely on the next MPI communication or collective operation.
Fixes Hermes-3 issue boutproject/hermes-3#448