Update BPIP-12 and BPIP-13 to match implementation#46
Open
zajck wants to merge 2 commits into
Open
Conversation
BPIP-12 (issues #1142, #1143): - Align executeMetaTransactionWithTokenTransferAuthorization signature: added _functionName, changed _nonce to uint256, replaced _sigR/_sigS/_sigV with _signature bytes, changed _tokenTransferAuthorization to abi.encode(bytes[]) - Fix ERC-3009 data encoding: remove from/to/value (passed from context), keep only validAfter/validBefore/nonce/v/r/s - Fix consumeForTransfer signature to include the 'to' parameter BPIP-13 (issue #1139): - Remove non-existent _computeBurnTokenId override; describe actual EXCHANGE_ID_2_2_0 versioning logic in ExchangeRedeemBase.burnVoucher - Document _skipVoucher=true flag used in the atomic commit-and-redeem path Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced May 22, 2026
Open
The implementation reverted from a single abi.encode(bytes[]) packed bytes to a direct bytes[] calldata parameter. Update the function signature and description accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BPIP-12 (issues #1142, #1143):
BPIP-13 (issue #1139):