update milliseconds to microseconds #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkuschel
approved these changes
Feb 4, 2023
tkuschel
left a comment
tkuschel
left a comment
There was a problem hiding this comment.
Unfortunately the function bme280_cal_meas_delay() gives milliseconds, and it would be also easy to change this function giving microseconds, so the scaling factor BME280_MEAS_SCALING_FACTOR would become obsolete. And the linux_userspace.c does not need to change. Just another commit request? So long nothing done here at Bosch. CR looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update milliseconds to microseconds