Skip to content

code compatibility readme with write functions #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SergeiSOficial wants to merge 4 commits into
base: master
Choose a base branch
from
Open

code compatibility readme with write functions #82

SergeiSOficial wants to merge 4 commits into from

Conversation

@SergeiSOficial
Copy link

@SergeiSOficial SergeiSOficial commented Nov 5, 2020

In code we have:

typedef BME280_INTF_RET_TYPE (*bme280_write_fptr_t)(uint8_t reg_addr, const uint8_t *reg_data, uint32_t len,
                                                    void *intf_ptr);

but in readme we need change:

int8_t user_spi_write(uint8_t reg_addr, uint8_t *reg_data, uint32_t len, void *intf_ptr)
int8_t user_i2c_write(uint8_t reg_addr, uint8_t *reg_data, uint32_t len, void *intf_ptr)

to this:

int8_t user_spi_write(uint8_t reg_addr, const uint8_t *reg_data, uint32_t len, void *intf_ptr)
int8_t user_i2c_write(uint8_t reg_addr, const uint8_t *reg_data, uint32_t len, void *intf_ptr)

@SergeiSOficial
Copy link
Author

SergeiSOficial commented Nov 5, 2020

And changed milliseconds to microseconds readme

b00bl1k
b00bl1k reviewed Feb 23, 2021
View reviewed changes
README.md Outdated
dev->settings.osr_t = BME280_OVERSAMPLING_2X;
dev->settings.filter = BME280_FILTER_COEFF_16;
dev->settings.standby_time = BME280_STANDBY_TIME_62_5_MS;
dev->settings.standby_time = BME280_STANDBY_TIME_62_5_us;
Copy link

@b00bl1k b00bl1k Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats wrong

bablokb added a commit to bablokb/BME280_driver that referenced this pull request Jun 10, 2021
@bablokb
integrate fixes from pull-request boschsensortec#82
3ddf12e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@b00bl1k b00bl1k b00bl1k left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SergeiSOficial @b00bl1k