Use unliftio over monad-control #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonchinn178
force-pushed
the
unliftio
branch
from
549efda to
e430450
Compare
|
@basvandijk what do you think about this one? |
|
It feels like the ecosystem is slowly moving away from monad-control. It would be great if this PR could be considered for merge. |
|
@brandonchinn178 just FYI, this branch was merged into my fork via this PR, alongside previously applied #24 |
This was referenced Dec 14, 2021
Open
avanov
pushed a commit
to avanov/pool
that referenced
this pull request
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #31
unliftioprovides async exception safety withmaskMonadUnliftIO, IMO, is a much better interface thanMonadBaseControl/MonadBase, and we should encourage users of this library to useunliftioinstead ofmonad-control