Skip to content

Add a calendar name to the ICS feed. #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bofrede wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add a calendar name to the ICS feed. #1912

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
601174d
Update views.py
bofrede Jul 16, 2025
450cf32
Update views.py
bofrede Jul 17, 2025
2488d72
Merge branch 'main' into patch-1
tykling Dec 22, 2025
3c66c6d
Merge branch 'main' into patch-1
tykling Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/program/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ def get(self, request, *args, **kwargs):
cal = icalendar.Calendar()
cal.add("prodid", "-//BornHack Website iCal Generator//bornhack.dk//")
cal.add("version", "2.0")
cal.add("NAME", "BornHack")
Copy link
Member

@tykling tykling Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cal.add("NAME", "BornHack")
cal.add("NAME", self.camp.title)

cal.add("X-WR-CALNAME", "BornHack")
Copy link
Member

@tykling tykling Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cal.add("X-WR-CALNAME", "BornHack")
cal.add("X-WR-CALNAME", self.camp.title)

Copy link
Author

@bofrede bofrede Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Author

@bofrede bofrede Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Bo! Would it make sense to include the year in the name?

I think not, but other conferences are doing it. Maybe we can try without the year.

Copy link
Member

@tykling tykling Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking if you have the bornhack ical thing added from 2025, and you then add the new one from 2026, having the same name for both of them would make it difficult to tell them apart (since we have different ical URLs per year)

for slot in event_slots:
cal.add_component(slot.get_ics_event())

Expand Down