Chunkerfixed sparse handling tests master#9589
Draft
ThomasWaldmann wants to merge 6 commits intoborgbackup:masterfrom
Draft
Chunkerfixed sparse handling tests master#9589ThomasWaldmann wants to merge 6 commits intoborgbackup:masterfrom
ThomasWaldmann wants to merge 6 commits intoborgbackup:masterfrom
Conversation
- Update fixed_test.py expectations for non-sparse chunking. - Enable `sparse=True` in interaction_test.py and reader_test.py where zero detection is required. - Catch `ValueError` in _build_fmap to support `BytesIO` seeking.
doesn't work anyway.
the fixed chunker also cuts BS blocks.
ThomasWaldmann
commented
May 4, 2026
| # this only works if sparse map blocks are same size as fixed chunker blocks | ||
| fn = str(tmpdir / fname) | ||
| make_sparsefile(fn, sparse_map, header_size=header_size) | ||
| get_chunks(fn, sparse=sparse, header_size=header_size) == make_content(sparse_map, header_size=header_size) |
Member
Author
There was a problem hiding this comment.
an assert was missing here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9589 +/- ##
==========================================
- Coverage 83.38% 82.25% -1.14%
==========================================
Files 87 87
Lines 15489 15489
Branches 2326 2326
==========================================
- Hits 12916 12740 -176
- Misses 1821 2011 +190
+ Partials 752 738 -14 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.