benchmark crud: suppress compact warnings during benchmark runs, fixes #9365 #9366
Merged
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom Feb 17, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9366 +/- ##
==========================================
- Coverage 76.44% 76.44% -0.01%
==========================================
Files 85 85
Lines 14792 14806 +14
Branches 2211 2213 +2
==========================================
+ Hits 11308 11318 +10
- Misses 2807 2810 +3
- Partials 677 678 +1 ☔ View full report in Codecov by Sentry. |
Member
|
Can you please check whether we have the same issue in 1.4-maint? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Done. Run "borg compact" to free space.warnings that clutterborg benchmark crudoutputmeasurement_run()callsdo_delete()3 times per test sample, each emitting the warning — 18 extra lines with the default 6 samples--json-linesmode, non-JSON warnings contaminate the JSON streamborg.archiverlogger level to ERROR during measurement runs, restoring it afterward via try/finallybenchmark_cmd.py, no interface changesCloses #9365
Checklist
masterpytest benchmark_cmd_test.py(4/4 passed) andborg benchmark crud --json-linesproduces clean JSON-only output