Conversation
|
Thanks for this, @duleorlovic . Looking at that whole section, I think we should re-arrange it to be modern Rails first. GitHub doesn't seem to let me make the suggestions on your PR. Do you mind if I put up a new PR that takes your suggestion and brings it first? I was thinking that we should say right off the top, something like:
And probably also a note that there isn't really that much in the styles, and they're free to define their own styling for the classes. |
|
Sure, it is easier to amend than to create new PR. Let me know if we need to explain more |
|
|
||
| If you followed the [official bootstrap installation guide](https://github.com/twbs/bootstrap-rubygem#a-ruby-on-rails), you'll probably have switched to SCSS. In this case add the following line to your `application.scss`: | ||
|
|
||
|
|
There was a problem hiding this comment.
I don't have enough GitHub fu to know how to do this better, so what I would suggest is something like move your added lines to after line 52. The current line 53 would become the last paragraph. We'd also have to update the wording, because it's been a long time since that was likely the "default" way of adding.
If you make those changes, then maybe I can make any other small edits via GitHub suggestions.
|
Thanks again for this. I think I didn't explain myself well. In hindsight, I realize I should just merge this, and then I can make further changes to the documentation. I really appreciate the PR! |
Not sure if older Rails versions work like this, but on Rails 8 and propshaft we need to use
@importwithout extensionIf I follow the current readme and use
then there is an error in javascript console