[BN] Update Dock widget to Sidebar widget#131
Open
clubby789 wants to merge 3 commits intobootleg:masterfrom
Open
[BN] Update Dock widget to Sidebar widget#131clubby789 wants to merge 3 commits intobootleg:masterfrom
clubby789 wants to merge 3 commits intobootleg:masterfrom
Conversation
Collaborator
|
Hi @clubby789, have you been been able to successfully use ret-sync with BinaryNinja and your changes at the end? |
|
Can't get it working with this PR in BN 5.1.8104-stable |
|
fix_widget_null_reference_errors.txt This changes are needed to make it work again in BN 5.1.8104-stable |
Fix self.widget access
Collaborator
|
Thanks @tGecko. Could you test the updated PR please? If it works as expected, I will merge it in the master branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #130
I still get
when trying to place a breakpoint - not sure if this is to do with my changes, other errors or if I'm just using the plugin wrong.