setup: Add python3-virt-firmware for bcvk

[cgwalters]

A better fix is in bootc-dev/bcvk#176

[gemini-code-assist]

Summary of Changes

Hello @cgwalters, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the bootc-ubuntu-setup GitHub Action by including the python3-virt-firmware package in its dependencies. This addition is intended to address a specific requirement for bcvk, as indicated by the associated issue, though a more comprehensive solution is noted to be under development.

Highlights

• Dependency Update: The python3-virt-firmware package has been added to the apt install command within the bootc-ubuntu-setup GitHub Action workflow.
• Contextual Reference: A comment has been added to the workflow, referencing https://github.com/bootc-dev/bcvk/issues/176, indicating this change is related to a known issue for bcvk.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds the python3-virt-firmware package to the setup dependencies for bcvk, which is a necessary fix as described in the linked issue. The change is correct. I've added a suggestion to improve the readability of the long apt install command by splitting it into multiple lines. This will make the list of packages easier to manage in the future.

[gemini-code-assist]

For better readability and maintainability, consider splitting this long apt install command across multiple lines. This makes the list of packages easier to read and manage.

        /bin/time -f '%E %C' sudo apt install -y \
          libkrb5-dev \
          pkg-config \
          libvirt-dev \
          genisoimage \
          qemu-utils \
          qemu-kvm \
          virtiofsd \
          libvirt-daemon-system \
          python3-virt-firmware