Skip to content

Conversation

@cgwalters
Copy link
Contributor

Renovate was updating GitHub Actions versions in target repositories but not in the common/ directory of this infra repo. This created a reconciliation loop where sync-common would overwrite Renovate's updates with older versions from common/.

Add renovate.json with explicit fileMatch patterns for the github-actions manager to scan both workflows and composite actions under common/.github/.

Fixes: bootc-dev/bootc#1865 (comment)

Assisted-by: OpenCode (Sonnet 4)

Renovate was updating GitHub Actions versions in target repositories
but not in the common/ directory of this infra repo. This created a
reconciliation loop where sync-common would overwrite Renovate's
updates with older versions from common/.

Add renovate.json with explicit fileMatch patterns for the
github-actions manager to scan both workflows and composite actions
under common/.github/.

Fixes: bootc-dev/bootc#1865 (comment)

Assisted-by: OpenCode (Sonnet 4)
Signed-off-by: Colin Walters <walters@verbum.org>
@gemini-code-assist
Copy link

Summary of Changes

Hello @cgwalters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical dependency management issue by configuring Renovate to properly scan and update GitHub Actions versions within the common/ directory. Previously, Renovate was not detecting these actions, leading to conflicts and outdated dependencies when sync-common processes ran. The addition of a dedicated renovate.json file with specific fileMatch patterns ensures that GitHub Actions workflows and composite actions are now correctly managed, thereby preventing version discrepancies and maintaining a consistent, up-to-date infrastructure.

Highlights

  • Renovate Configuration: Introduced a new renovate.json file to explicitly configure Renovate to scan GitHub Actions workflows and composite actions located within the .github/workflows and .github/actions directories under common/.
  • Issue Resolution: This change resolves a reconciliation loop where sync-common would overwrite Renovate's updates with older versions from the common/ directory, ensuring consistent dependency management for GitHub Actions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to configure Renovate to scan for GitHub Actions in the common/ directory. I've found two critical issues in the new renovate.json configuration. First, the extends path for the shared configuration is invalid and will likely cause Renovate to fail. Second, the fileMatch regular expressions do not correctly target the files within the common/ directory and also might be too permissive. My review includes suggestions to fix both of these issues to ensure the configuration works as intended.

@cgwalters cgwalters enabled auto-merge (squash) December 17, 2025 23:01
Copy link
Contributor

@gursewak1997 gursewak1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt

@cgwalters cgwalters merged commit 2de1f74 into bootc-dev:main Dec 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants