-
Notifications
You must be signed in to change notification settings - Fork 3
renovate: Add config to scan common/ for GitHub Actions #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Renovate was updating GitHub Actions versions in target repositories but not in the common/ directory of this infra repo. This created a reconciliation loop where sync-common would overwrite Renovate's updates with older versions from common/. Add renovate.json with explicit fileMatch patterns for the github-actions manager to scan both workflows and composite actions under common/.github/. Fixes: bootc-dev/bootc#1865 (comment) Assisted-by: OpenCode (Sonnet 4) Signed-off-by: Colin Walters <walters@verbum.org>
Summary of ChangesHello @cgwalters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical dependency management issue by configuring Renovate to properly scan and update GitHub Actions versions within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to configure Renovate to scan for GitHub Actions in the common/ directory. I've found two critical issues in the new renovate.json configuration. First, the extends path for the shared configuration is invalid and will likely cause Renovate to fail. Second, the fileMatch regular expressions do not correctly target the files within the common/ directory and also might be too permissive. My review includes suggestions to fix both of these issues to ensure the configuration works as intended.
gursewak1997
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgmt
Renovate was updating GitHub Actions versions in target repositories but not in the common/ directory of this infra repo. This created a reconciliation loop where sync-common would overwrite Renovate's updates with older versions from common/.
Add renovate.json with explicit fileMatch patterns for the github-actions manager to scan both workflows and composite actions under common/.github/.
Fixes: bootc-dev/bootc#1865 (comment)
Assisted-by: OpenCode (Sonnet 4)