[feature] Add build option for Cobalt IO SSL#277
Open
uilianries wants to merge 2 commits into
Open
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
uilianries
changed the title
Author
|
The current CI erros are related to setup steps: Can not clone: https://drone.cpp.al/boostorg/cobalt/1161/2/3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This PR implements the suggestion #274 by including a new option to build or not cobalt_io_ssl only. It avoids including a new external dependency (OpenSSL) when building Boost, but keeps the possibility of building Cobalt altogether.
As the new option is introduced for both CMake and b2 builds, I checked locally every combination. By default, it will keep the previous behavior; only when set to OFF will it be disabled.
Regards!
closes #274