Skip to content

Correct CMake version check; VERSION_GREATER 3.18 is true for 3.18.1 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaquintides merged 1 commit into from
Oct 20, 2025
Merged

Correct CMake version check; VERSION_GREATER 3.18 is true for 3.18.1 #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,17 @@ target_link_libraries(boost_bloom

target_compile_features(boost_bloom INTERFACE cxx_std_11)

if(BUILD_TESTING AND EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/test/CMakeLists.txt")
if(NOT CMAKE_VERSION VERSION_LESS 3.19 AND CMAKE_GENERATOR MATCHES "Visual Studio")

add_subdirectory(test)
file(GLOB_RECURSE boost_bloom_IDEFILES CONFIGURE_DEPENDS "include/*.hpp")
source_group(TREE ${PROJECT_SOURCE_DIR}/include FILES ${boost_bloom_IDEFILES} PREFIX "Header Files")
list(APPEND boost_bloom_IDEFILES extra/boost_bloom.natvis)
target_sources(boost_bloom PRIVATE ${boost_bloom_IDEFILES})

endif()

if(CMAKE_VERSION VERSION_GREATER 3.18 AND CMAKE_GENERATOR MATCHES "Visual Studio")
if(BUILD_TESTING AND EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/test/CMakeLists.txt")

file(GLOB_RECURSE boost_bloom_IDEFILES CONFIGURE_DEPENDS "include/**/*.hpp")
source_group(TREE ${PROJECT_SOURCE_DIR}/include FILES ${boost_bloom_IDEFILES} PREFIX "Header Files")
list(APPEND boost_bloom_IDEFILES extra/boost_bloom.natvis)
target_sources(boost_bloom PRIVATE ${boost_bloom_IDEFILES})
add_subdirectory(test)

endif()