Skip to content

Conversation

@ILer32
Copy link
Contributor

@ILer32 ILer32 commented Dec 19, 2025

Problem:

  • The summary messages are incorrect (assertions, passed, fails, and n_tests are wrong for some sample codes)
  • "expect(fatal(false));" counts fails for 2 times
  • README.md could be updated

Solution:

  • Correct the calculation process for different results (assertions, passed, fails, and n_tests)
  • Introduce test_result.fail_tests to count the failed n_tests
  • Update README.md

Issue: #695

Reviewers:
@kris-jusiak

@kris-jusiak kris-jusiak merged commit b9c2d79 into boost-ext:master Dec 20, 2025
8 of 9 checks passed
@kris-jusiak
Copy link
Contributor

thank you @ILer32

@ILer32
Copy link
Contributor Author

ILer32 commented Dec 20, 2025

@kris-jusiak, thank you for your timely review and merge. I enjoyed the process and studied the program during coding.
I may post issues and Pull Requests in the future.
Feel free to mention me and edit my Pull Requests as needed.

@ILer32 ILer32 deleted the add-otto branch December 20, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants