fix windows fullscreen rendering keyboard demo#34
Open
jbolda wants to merge 1 commit into
Open
Conversation
commit: |
Contributor
|
Yikes! Is there anywhere we can read up on the differences of fullscreen on windows? |
Author
|
I was reading through this last night, but I haven't seen anything explicitly pointing to the issue, at least that buffered fullscreen write issue specifically. |
Contributor
|
Hmmm. Nothing leaps out to me about how this might be different than the way other terminal emulators handle it. Maybe we can ask a robot why that fix works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The bottom of our demos were clipped around ~20px.
Approach
Seems to be related to the fullscreen handling on windows? I don't love that you need to know about this "in userland", but this at least appears to resolve the issue. Getting this up that we can opt to refine as we see fit.