Fix coerce() returning NaN for non-numeric digit-starting strings#15
Open
nvie wants to merge 2 commits intobombshell-dev:mainfrom
Open
Fix coerce() returning NaN for non-numeric digit-starting strings#15nvie wants to merge 2 commits intobombshell-dev:mainfrom
nvie wants to merge 2 commits intobombshell-dev:mainfrom
Conversation
Strings like "3.7.1" or "1abc" start with a digit but aren't valid numbers. The coerce function was blindly returning Number(value), producing NaN. Now it checks isNaN before returning the numeric result, falling back to the original string.
🦋 Changeset detectedLatest commit: 5f88b66 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
coerce(): it was converting any digit-starting string toNumber(value), even when the result isNaN(e.g."3.7.1","1abc")isNaNguard so invalid conversions fall back to the original stringFor example:
parse(["3.7.1"])→{ _: ["3.7.1"] }(was{ _: [NaN] })parse(["1abc"])→{ _: ["1abc"] }(was{ _: [NaN] })parse(["--version", "3.7.1"])→{ version: "3.7.1" }(was{ version: NaN })"42"→42,".5"→0.5,"3.14"→3.14