Open
Conversation
7cabb2f to
503ee7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tightens mark-sweep teardown/finalization semantics with minimal scope.
What changed
FinalizeFn) soGcBox<T>finalizers can be dispatched correctly from erased pointers.sweep_all_queues) to runfinalize_fnbeforedrop_fnfor:root_queuepending_root_queueephemeron_queuepending_ephemeron_queueTrace::run_finalizer(...).collector_drop_runs_finalizers_for_live_gc_valuescollector_drop_runs_ephemeron_value_finalizers_for_live_valuesWhy
Previous teardown behavior reliably dropped live tracked allocations, but finalizer execution for erased GC values was incomplete/inconsistent. This patch keeps the PR focused to mark-sweep internals and guarantees finalizers are run during collector teardown where safe.
Scope
Validation
cargo fmt --all -- --checkcargo test --workspacecargo clippy --workspace --all-features --all-targetscargo clippy --workspace --no-default-features --all-targetscargo doc -v --document-private-items --all-features