Skip to content

ci: add test suite and nightly miri jobs#42

Open
shruti2522 wants to merge 2 commits intoboa-dev:mainfrom
shruti2522:miri-ci
Open

ci: add test suite and nightly miri jobs#42
shruti2522 wants to merge 2 commits intoboa-dev:mainfrom
shruti2522:miri-ci

Conversation

@shruti2522
Copy link
Contributor

Add cargo test and MIRI test suite to CI

@shruti2522 shruti2522 marked this pull request as draft March 9, 2026 05:16
@shruti2522 shruti2522 marked this pull request as ready for review March 9, 2026 05:40
@nekevss
Copy link
Member

nekevss commented Mar 9, 2026

Honestly, let's try and run MIRI on every PR.

If it doesn't blow up CI runtime, I'd prefer to have the face value safety. We don't run it on Boa because it would take too long, but this is a smaller repo (for now), so we should try running it.

@shruti2522
Copy link
Contributor Author

Honestly, let's try and run MIRI on every PR.

If it doesn't blow up CI runtime, I'd prefer to have the face value safety. We don't run it on Boa because it would take too long, but this is a smaller repo (for now), so we should try running it.

I agree, MIRI run doesn't blow up the CI runtime as of now, the only exception was the gc_recursion test, which was taking a really long time, but I've resolved that by using cfg(miri) and cfg(not(miri)) flags. We should be good to run it on every PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants