Bhamehta/code cleanup

.github/workflows/build-android.yml

@@ -17,13 +17,18 @@ on:
     - main
     - dev
 
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
 jobs:
   build:
     runs-on: windows-latest
     name: Build for Android
     steps:
     - name: Checkout
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         submodules: false
     - name: Update submodules
@@ -32,22 +37,21 @@ jobs:
         git config --global submodule.lib/modules.update none
         git -c protocol.version=2 submodule update --init --force --depth=1
     - name: Setup Java
-      uses: actions/setup-java@v3
+      uses: actions/setup-java@v5
       with:
         distribution: 'adopt'
         java-version: '17'
     - name: Remove default github maven configuration
       # Workaround for: 'Unable to decrypt local Maven settings credentials'
       run: rm $Env:USERPROFILE\.m2\settings.xml
     - name: Setup Android SDK
-      uses: android-actions/setup-android@v2
+      uses: android-actions/setup-android@v3
     - name: Install NDK
       run: |
         java -version
         gci env:* | sort-object name
-        new-item "C:\Users\runneradmin\.android\repositories.cfg" -ItemType "file"
-        echo yes | .\sdkmanager.bat "ndk-bundle" "cmake;3.10.2.4988404" "ndk;27.0.12077973" --sdk_root=$Env:ANDROID_SDK_ROOT
-      working-directory: ${{ env.ANDROID_SDK_ROOT }}\cmdline-tools\7.0\bin
+        new-item "$Env:USERPROFILE\.android\repositories.cfg" -ItemType "file"
+        echo yes | sdkmanager "ndk-bundle" "cmake;3.10.2.4988404" "ndk;27.0.12077973" --sdk_root=$Env:ANDROID_SDK_ROOT
     - name: Chocolatey
       run: |
         choco install --no-progress -y ninja

.github/workflows/build-ios-mac.yml

@@ -19,36 +19,42 @@ on:
   schedule:
   - cron: 0 2 * * 1-5
 
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
 jobs:
   build:
     strategy:
       matrix:
-        os: [macos-13, macos-15]
+        os: [macos-14, macos-15]
         config: [release, debug]
         simulator: ["'iPhone 15'", "'iPad Pro (11-inch) (4th generation)'", "'iPhone 16'", "'iPad Air 11-inch (M2)'"]
         exclude:
-          - os: macos-13
+          - os: macos-14
             simulator: "'iPhone 16'"
-          - os: macos-13
+          - os: macos-14
             simulator: "'iPad Air 11-inch (M2)'"
           - os: macos-15
             simulator: "'iPhone 15'"
           - os: macos-15
             simulator: "'iPad Pro (11-inch) (4th generation)'"
     runs-on: ${{ matrix.os }}
+    timeout-minutes: 30
     env:
       CMAKE_POLICY_VERSION_MINIMUM: "3.5"
     steps:
     - name: Grant write permissions to /usr/local
       run: |
         sudo chown -R $USER:staff /usr/local
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
       with:
         submodules: 'true'
       continue-on-error: true
     - name: build
       run: |
-        if [[ "${{ matrix.os }}" == "macos-13" ]]; then
+        if [[ "${{ matrix.os }}" == "macos-14" ]]; then
           export IOS_DEPLOYMENT_TARGET=13.0;
         elif [[ "${{ matrix.os }}" == "macos-15" ]]; then
           export IOS_DEPLOYMENT_TARGET=15.0;

.github/workflows/build-posix-latest.yml

@@ -19,6 +19,11 @@ on:
   schedule:
   - cron: 0 2 * * 1-5
 
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
 jobs:
   build:
 
@@ -32,7 +37,7 @@ jobs:
 
     steps:
     - name: Checkout
-      uses: actions/checkout@v1
+      uses: actions/checkout@v4
       continue-on-error: true
     - name: Test ${{ matrix.os }} ${{ matrix.config }}
       run: ./build-tests.sh ${{ matrix.config }}

.github/workflows/build-ubuntu-2204.yml

@@ -19,6 +19,11 @@ on:
   schedule:
   - cron: 0 2 * * 1-5
 
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
 jobs:
   build:
 
@@ -32,7 +37,7 @@ jobs:
 
     steps:
     - name: Checkout
-      uses: actions/checkout@v1
+      uses: actions/checkout@v4
       continue-on-error: true
     - name: Test ${{ matrix.os }} ${{ matrix.config }}
       run: ./build-tests.sh ${{ matrix.config }}

.github/workflows/build-windows-clang.yaml.off

@@ -22,7 +22,7 @@ jobs:
     steps:
 
     - name: Checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
       continue-on-error: true
 
     - name: Setup Tools

.github/workflows/build-windows-vs2017.yaml.off

@@ -22,7 +22,7 @@ jobs:
     steps:
 
     - name: Checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
       continue-on-error: true
 
     - name: Setup Tools

.github/workflows/build-windows-vs2022.yaml

@@ -22,7 +22,7 @@ jobs:
     steps:
 
     - name: Checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
       continue-on-error: true
 
     - name: Build

.github/workflows/codeql-analysis.yml

@@ -14,6 +14,11 @@ on:
   schedule:
     - cron: '0 8 * * 1'
 
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
 jobs:
   analyze:
     name: Analyze
@@ -34,7 +39,7 @@ jobs:
 
     steps:
     - name: Checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
       continue-on-error: true
 
     # Initializes the CodeQL tools for scanning.
@@ -87,7 +92,7 @@ jobs:
 
     steps:
     - name: Checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
       continue-on-error: true
 
     - name: Update submodules
@@ -102,21 +107,20 @@ jobs:
         languages: java
 
     - name: Setup Java
-      uses: actions/setup-java@v3
+      uses: actions/setup-java@v5
       with:
         distribution: 'adopt'
         java-version: '17'
     - name: Remove default github maven configuration
       run: rm $Env:USERPROFILE\.m2\settings.xml
     - name: Setup Android SDK
-      uses: android-actions/setup-android@v2
+      uses: android-actions/setup-android@v3
     - name: Install NDK
       run: |
         java -version
         gci env:* | sort-object name
-        new-item "C:\Users\runneradmin\.android\repositories.cfg" -ItemType "file"
-        echo yes | .\sdkmanager.bat "ndk-bundle" "cmake;3.10.2.4988404" "ndk;27.0.12077973" --sdk_root=$Env:ANDROID_SDK_ROOT
-      working-directory: ${{ env.ANDROID_SDK_ROOT }}\cmdline-tools\7.0\bin
+        new-item "$Env:USERPROFILE\.android\repositories.cfg" -ItemType "file"
+        echo yes | sdkmanager "ndk-bundle" "cmake;3.10.2.4988404" "ndk;27.0.12077973" --sdk_root=$Env:ANDROID_SDK_ROOT
     - name: Chocolatey
       run: |
         choco install --no-progress -y ninja

.github/workflows/spellcheck.yml

@@ -6,14 +6,19 @@ on:
   pull_request:
     branches: [ master, main ]
 
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
 jobs:
   build:
     runs-on: ubuntu-latest
 
     steps:
 
     - name: Checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
       continue-on-error: true
 
     - name: install misspell

.github/workflows/test-android-mac.yml.off

@@ -26,7 +26,7 @@ jobs:
     steps:
 
     - name: Checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
       with:
         submodules: true
         depth: 1
@@ -42,7 +42,7 @@ jobs:
         script: ./testandlog
     - name: Upload
       if: ${{ always() }}
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: logcat
         path: ./lib/android_build/logcat.txt

.github/workflows/test-win-latest.yml

@@ -19,6 +19,11 @@ on:
   schedule:
   - cron: 0 2 * * 1-5
 
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
 jobs:
   test:
     name: Test on Windows ${{ matrix.arch }}-${{ matrix.build }}
@@ -32,13 +37,13 @@ jobs:
     steps:
 
     - name: Checkout
-      uses: actions/checkout@v1
+      uses: actions/checkout@v4
       continue-on-error: true
 
     - name: setup-msbuild
-      uses: microsoft/setup-msbuild@v1.1
+      uses: microsoft/setup-msbuild@v2
       with:
-        vs-version: '[16,)'
+        vs-version: '[17,)'
 
     - name: Test ${{ matrix.arch }} ${{ matrix.build }}
       shell: cmd

.readthedocs.yaml

@@ -1,11 +1,19 @@
 version: 2
 
+build:
+  os: ubuntu-24.04
+  tools:
+    python: "3.12"
+  apt_packages:
+    - doxygen
+    - graphviz
+
 submodules:
   exclude: all
 
 python:
-   install:
-   - requirements: docs/public/requirements.txt
+  install:
+    - requirements: docs/public/requirements.txt
 
 sphinx:
-   configuration: docs/public/conf.py
+  configuration: docs/public/conf.py