Skip to content

[PW_SID:1104005] [v2] bluetooth: btintel: Add Bluetooth SAR revision 2 support#267

Open
BluezTestBot wants to merge 1 commit into
workflowfrom
1104005
Open

[PW_SID:1104005] [v2] bluetooth: btintel: Add Bluetooth SAR revision 2 support#267
BluezTestBot wants to merge 1 commit into
workflowfrom
1104005

Conversation

@BluezTestBot
Copy link
Copy Markdown

BRDS revision 2 introduces per-chain (Chain A and Chain B) TX power
limits across five sub-bands (2.4G, 5.2G, 5.8/5.9G, 6G-low, 6G-high),
replacing the single-chain per-modulation model of revisions 0 and 1.

  • Add btintel_set_sar_rev2() which sends the full Rev2 DDC sequence:
    0x019e inc-power-mode enable flag (1 byte)
    0x0311 2.4 GHz sub-band limits (2 bytes)
    0x0312 5.2 GHz sub-band limits (2 bytes)
    0x0313 5.8/5.9 GHz sub-band limits (2 bytes)
    0x0314 5.8/5.9 GHz sub-band limits again (2 bytes, duplicate FW reg)
    0x0315 6 GHz low sub-band limits (2 bytes)
    0x0316 6 GHz high sub-band limits (2 bytes)
    followed by the SAR-init-complete command (0xfe25).

logs from dmesg when BTSAR2 is enabled in Coreboot/BIOS:

Bluetooth: hci0: BT SAR Rev2: revision=2 bt_sar_bios=1 inc_power_mode=1
Bluetooth: hci0: BT SAR Rev2 Chain A: 2g4=76 5g2=0 5g8_5g9=0 6g1=0 6g3=0
Bluetooth: hci0: BT SAR Rev2 Chain B: 2g4=102 5g2=0 5g8_5g9=0 6g1=0 6g3=0

Signed-off-by: Ravindra ravindra@intel.com
Signed-off-by: Kiran K kiran.k@intel.com

changes in v2:

  • Update commit message to include logs
  • Validate the ACPI types/size before accessing.

drivers/bluetooth/btintel.c | 195 +++++++++++++++++++++++++++++++++++-
drivers/bluetooth/btintel.h | 18 ++++
2 files changed, 212 insertions(+), 1 deletion(-)

BRDS revision 2 introduces per-chain (Chain A and Chain B) TX power
limits across five sub-bands (2.4G, 5.2G, 5.8/5.9G, 6G-low, 6G-high),
replacing the single-chain per-modulation model of revisions 0 and 1.

- Add btintel_set_sar_rev2() which sends the full Rev2 DDC sequence:
    0x019e  inc-power-mode enable flag        (1 byte)
    0x0311  2.4 GHz sub-band limits           (2 bytes)
    0x0312  5.2 GHz sub-band limits           (2 bytes)
    0x0313  5.8/5.9 GHz sub-band limits       (2 bytes)
    0x0314  5.8/5.9 GHz sub-band limits again (2 bytes, duplicate FW reg)
    0x0315  6 GHz low sub-band limits         (2 bytes)
    0x0316  6 GHz high sub-band limits        (2 bytes)
  followed by the SAR-init-complete command (0xfe25).

logs from dmesg when BTSAR2 is enabled in Coreboot/BIOS:

Bluetooth: hci0: BT SAR Rev2: revision=2 bt_sar_bios=1 inc_power_mode=1
Bluetooth: hci0: BT SAR Rev2 Chain A: 2g4=76 5g2=0 5g8_5g9=0 6g1=0 6g3=0
Bluetooth: hci0: BT SAR Rev2 Chain B: 2g4=102 5g2=0 5g8_5g9=0 6g1=0 6g3=0

Signed-off-by: Ravindra <ravindra@intel.com>
Signed-off-by: Kiran K <kiran.k@intel.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

CheckPatch
Desc: Run checkpatch.pl script
Duration: 1.19 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

VerifyFixes
Desc: Verify Fixes tag format and validity
Duration: 0.16 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

VerifySignedoff
Desc: Verify Signed-off-by chain
Duration: 0.14 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

GitLint
Desc: Run gitlint
Duration: 0.36 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

SubjectPrefix
Desc: Check subject contains "Bluetooth" prefix
Duration: 0.13 seconds
Result: FAIL
Output:

"Bluetooth: " prefix is not specified in the subject

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

BuildKernel
Desc: Build Kernel for Bluetooth
Duration: 28.45 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

CheckAllWarning
Desc: Run linux kernel with all warning enabled
Duration: 29.87 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

CheckSparse
Desc: Run sparse tool with linux kernel
Duration: 26.84 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

BuildKernel32
Desc: Build 32bit Kernel for Bluetooth
Duration: 24.85 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

TestRunnerSetup
Desc: Setup kernel and bluez for test-runner
Duration: 536.15 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

IncrementalBuild
Desc: Incremental build with the patches in the series
Duration: 24.15 seconds
Result: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants