Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jan 29, 2025

NTN Support for Hub Module

This PR adds Non-Terrestrial Network (NTN) support to the hub module, with improved parameter handling and documentation.

Changes

  • Added out and in_ parameters to hub.sync for selective sync control
  • Updated allow parameter documentation to accurately reflect penalty box behavior
  • Removed undocumented ntn parameter
  • Added comprehensive test coverage for NTN-related functionality
  • Implemented proper parameter name mapping in tests (in_ -> in)
  • Verified correct boolean value handling in JSON serialization
  • Added explicit tests for boolean parameter serialization

Testing

  • Added test cases for all new parameters and combinations
  • Verified parameter mapping functionality
  • Confirmed boolean values are correctly serialized in JSON requests
  • All tests passing across Python versions 3.6 to 3.11

Documentation

  • Updated parameter descriptions to match official Blues documentation
  • Clarified penalty box behavior in allow parameter
  • Added documentation for selective sync parameters
  • Added examples of JSON request format in docstrings

Link to Devin run: https://app.devin.ai/sessions/95ffd763d71b445198b9370e49dcd93f

Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

devin-ai-integration bot and others added 7 commits January 29, 2025 18:27
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
Co-Authored-By: rlauer@blues.com <rlauer@blues.com>
@devin-ai-integration
Copy link
Contributor Author

Closing due to inactivity.

@rdlauer rdlauer deleted the devin/1738175048-ntn-hub-support branch February 10, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant