test: cover NotePing behavior#241
Merged
Merged
Conversation
zfields
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a companion PR for #239.
It adds one commit on top of
ray/autobaudthat:_noteTransactionShouldLock()reset behavior, removing the best-effort reset policy from feat: NotePing() allows for testing to see if a notecard is responding sans delays/retry #239NotePing()APINotePing test coverage
NotePing_testcovers:errresetRequiredis already setVerification
Result:
NotePing_test: 30 assertions passedNoteTransaction_test: 124 assertions passedI tried pushing this commit directly to
blues:ray/autobaud, but GitHub rejectedzakoverflowwith a 403, so this branch is available to merge or cherry-pick into #239.