stm32l4: Set proper USB and HAL tick interrupt priorities for L433 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can set some of them lower than 13 if necessary on a per-port basis. At least esp32 and arm ports all use 13 from what I could see.
This behavior is in line with standard Python Closes: adafruit#9768
…tart`, `synthio.Note.waveform_loop_end`, `synthio.Note.ring_waveform_loop_start`, and `synthio.Note.ring_waveform_loop_end`.
rp2350 doesn't have the same RTC peripheral as the 2040 (let alone other family micros) this has the side effect of obeying a different timesource if one has been configured.
Currently translated at 37.3% (372 of 997 strings) Translation: CircuitPython/main Translate-URL: https://hosted.weblate.org/projects/circuitpython/main/id/
This means that the variant no longer needs to be explicitly named and you can just run `make test`.
.. and add a very basic audioeffects test, showing that it plausibly is working I had to address several build errors that occurred in the Unix build, mostly related to conversion from FP types to integral types (replaced by explicit casts) and by accidental mixing of regular & f-suffixed floating constants (replaced with the MICROPY_FLOAT_CONST macro) Particularly this change could use consideration: ```diff - self->max_echo_buffer_len = self->sample_rate / 1000.0f * max_delay_ms * (self->channel_count * sizeof(uint16_t)); // bytes + self->max_echo_buffer_len = (uint32_t)(self->sample_rate / 1000.0f * max_delay_ms) * (self->channel_count * sizeof(uint16_t)); // bytes ``` The buffer length is being calculated in floating point based on the millisecond delay & the sample rate. The result could then be a fractional number such as 529.2 for a 12ms delay at 44.1kHz. Multiplying a floating number by the size required for each echo buffer item (`(self->channel_count * sizeof(uint16_t))`) could yield a number of bytes that doesn't correspond to an integral number of buffer items. I grouped the float->int conversion so that it converts the number of echo buffer items to an integer and then multiplies by the size of the item.
extra call to serial_early_init.
- Set USB interrupt priority to 1 for STM32L433 - Lower HAL tick interrupt priority to 2 to ensure proper USB operation - Ensures proper interrupt handling for USB functionality Co-Authored-By: bsatrom@blues.com <bsatrom@blues.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
Co-Authored-By: bsatrom@blues.com <bsatrom@blues.com>
Co-Authored-By: bsatrom@blues.com <bsatrom@blues.com>
Co-Authored-By: bsatrom@blues.com <bsatrom@blues.com>
- Add proper null checks for workflow and check suite data - Add timeout to GitHub API requests - Improve error messages and exception handling - Add type checking for pagination - Handle missing page info gracefully Co-Authored-By: bsatrom@blues.com <bsatrom@blues.com>
- Add type checking for name parameter - Add validation for pagination direction - Add null check for cursor value - Improve error messages for invalid cases Co-Authored-By: bsatrom@blues.com <bsatrom@blues.com>
Co-Authored-By: bsatrom@blues.com <bsatrom@blues.com>
Author
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USB Interrupt Priority Configuration for STM32L433
This PR implements proper USB interrupt priority configuration for the STM32L433-based Cygnet board:
These changes should improve USB stability and reliability on the Cygnet board by:
Link to Devin run: https://app.devin.ai/sessions/a1b02f88c6264953b8940e73982645c8
Testing