Skip to content

Conversation

@patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Jan 13, 2026

Fix #3547

image

Summary by Sourcery

New Features:

  • Display an informational alert explaining how the DHCP backup server behaves when enabled.

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 13, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds an informational alert to the DHCPServerDialog explaining the behavior when the Backup Server option is enabled, improving user understanding of backup server behavior.

File-Level Changes

Change Details Files
Add an informational alert below the Backup Server switch explaining backup server behavior.
  • Insert a Vuetify v-alert component configured as dense, text, and type='info'
  • Place the alert immediately under the Backup Server v-switch within the dialog layout
  • Set the alert message to clarify that the DHCP server remains inactive and only serves IPs when no other DHCP server is detected
core/frontend/src/components/ethernet/DHCPServerDialog.vue

Assessment against linked issues

Issue Objective Addressed Explanation
#3547 Add in-UI documentation/description explaining how the Backup DHCP Server behaves in BlueOS.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The informational alert text is hardcoded in English; consider using the existing i18n / localization mechanism used elsewhere in the frontend so the message can be translated.
  • The alert is always shown even when is_backup_server is false; consider conditionally rendering it (e.g. v-if="is_backup_server") so the message only appears when the backup server option is enabled.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The informational alert text is hardcoded in English; consider using the existing i18n / localization mechanism used elsewhere in the frontend so the message can be translated.
- The alert is always shown even when `is_backup_server` is false; consider conditionally rendering it (e.g. `v-if="is_backup_server"`) so the message only appears when the backup server option is enabled.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@joaomariolago joaomariolago merged commit 9916be5 into bluerobotics:master Jan 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backup DHCP Server needs a description in BlueOS itself

2 participants