Add missing tooltips

[patrickelectric]

Fix #3613

Summary by Sourcery

Add descriptive tooltips to various tray menu icons to clarify their status and actions.

New Features:

• Add dynamic tooltip indicating Pirate Mode enabled/disabled state and how to change it.
• Add tooltip describing Ethernet connectivity status in the Ethernet tray menu.
• Add tooltip explaining on-board computer reboot requirement tray icon action.
• Add tooltip explaining system checker alert tray icon action.
• Add tooltip explaining vehicle reboot required tray icon action.
• Add tooltip describing cloud synchronization status icon.

Bug Fixes:

• Correct tooltip binding on the beacon tray menu icon to use the proper v-tooltip directive.

[sourcery-ai]

Reviewer's Guide

Adds missing Vuetify tooltips to several tray menu icons and introduces computed tooltip text for pirate mode and Ethernet connectivity.

Class diagram for updated tray menu tooltip logic

classDiagram
  class PirateModeTrayMenu {
    +boolean show_menu
    +Settings settings
    +pirate_mode_tooltip() string
    +showMenu(show boolean) void
  }

  class EthernetTrayMenu {
    +available_interfaces list~EthernetInterface~
    +interface_icon() string
    +interface_connected_tooltip() string
  }

  class BeaconTrayMenu {
    +tooltip_text string
  }

  class OnBoardComputerRequiredTrayMenu {
    +icon mdi_restart_alert
  }

  class SystemCheckerTrayMenu {
    +icon mdi_alert
  }

  class VehicleRebootRequiredTrayMenu {
    +icon mdi_restart_alert
  }

  class CloudTrayMenu {
    +icon cloud_sync_status
  }

  class Settings {
    +boolean is_pirate_mode
  }

  class EthernetInterfaceInfo {
    +boolean connected
  }

  class EthernetInterface {
    +EthernetInterfaceInfo info
  }

  PirateModeTrayMenu --> Settings : uses
  EthernetTrayMenu "*" --> EthernetInterface : filters
  EthernetInterface --> EthernetInterfaceInfo : has
  PirateModeTrayMenu ..> v-tooltip_pirate_mode_tooltip : tooltip_binding
  EthernetTrayMenu ..> v-tooltip_interface_connected_tooltip : tooltip_binding
  BeaconTrayMenu ..> v-tooltip_tooltip_text : tooltip_binding
  OnBoardComputerRequiredTrayMenu ..> v-tooltip_static_text : tooltip_binding
  SystemCheckerTrayMenu ..> v-tooltip_static_text : tooltip_binding
  VehicleRebootRequiredTrayMenu ..> v-tooltip_static_text : tooltip_binding
  CloudTrayMenu ..> v-tooltip_static_text : tooltip_binding

Loading

File-Level Changes

Change	Details	Files
Add computed tooltip text for pirate mode tray icon based on current state.	Attach v-tooltip binding to the pirate mode v-icon in the tray menu. Introduce pirate_mode_tooltip computed property that returns dynamic text reflecting whether pirate mode is enabled or disabled.	core/frontend/src/components/app/PirateModeTrayMenu.vue
Expose Ethernet connectivity status via tooltip on the Ethernet tray icon.	Attach v-tooltip binding to the Ethernet tray v-icon. Add interface_connected_tooltip computed property that derives tooltip text from available_interfaces connectivity state.	core/frontend/src/components/ethernet/EthernetTrayMenu.vue
Fix and standardize tooltip bindings for beacon and various status tray icons using static strings where appropriate.	Switch BeaconTrayMenu v-icon from bound :v-tooltip to directive-style v-tooltip using existing tooltip_text. Add static v-tooltip strings to the OnBoardComputerRequiredTrayMenu, SystemCheckerTrayMenu, VehicleRebootRequiredTrayMenu, and CloudTrayMenu v-icons for clearer UX.	core/frontend/src/components/beacon/BeaconTrayMenu.vue core/frontend/src/components/app/OnBoardComputerRequiredTrayMenu.vue core/frontend/src/components/app/SystemCheckerTrayMenu.vue core/frontend/src/components/app/VehicleRebootRequiredTrayMenu.vue core/frontend/src/components/cloud/CloudTrayMenu.vue

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#3613	Add tooltip text to all top bar status icons that currently lack tooltips, including the throttling and low voltage icons.	❌	The PR adds or fixes tooltips for several tray menu icons (pirate mode, ethernet, beacon, on-board computer required, system checker, vehicle reboot required, and cloud sync), but there are no changes related to throttling or low voltage icons. Therefore, not all top bar icons mentioned in the issue are covered.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In PirateModeTrayMenu.vue, consider referencing this.settings inside the pirate_mode_tooltip computed property for consistency with the rest of the component and to make reactivity more obvious.
• In EthernetTrayMenu.vue, the logic to compute connected_interfaces is duplicated between interface_connected_icon and interface_connected_tooltip; extracting this into a shared computed/getter would reduce repetition and potential divergence.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `PirateModeTrayMenu.vue`, consider referencing `this.settings` inside the `pirate_mode_tooltip` computed property for consistency with the rest of the component and to make reactivity more obvious.
- In `EthernetTrayMenu.vue`, the logic to compute `connected_interfaces` is duplicated between `interface_connected_icon` and `interface_connected_tooltip`; extracting this into a shared computed/getter would reduce repetition and potential divergence.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[joaoantoniocardoso]

I believe this should be a bind just like it was?

Suggested change

	v-tooltip="tooltip_text"
	:v-tooltip="tooltip_text"

[patrickelectric]

That's not necessary

[joaoantoniocardoso]

shouldn't it be a bind?

Suggested change

	v-tooltip="interface_connected_tooltip"
	:v-tooltip="interface_connected_tooltip"

[patrickelectric]

That's not necessary

[joaoantoniocardoso]

I think I'll never be used to Vue 😭