Skip to content

Fix[rmqa_compressiontransformerimpl]: check compression properties #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willhoy merged 5 commits into from
Mar 17, 2026
Merged

Fix[rmqa_compressiontransformerimpl]: check compression properties #76

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f60396
Fix[rmqa_compressiontransformerimpl.cpp]: check compression propertie…
678098 Mar 12, 2026
8d06fe0
Rename header -> property
678098 Mar 12, 2026
53256b4
Update rmqa_compressiontransformerimpl.cpp
678098 Mar 12, 2026
96f906e
Merge branch 'main' into patch-4
willhoy Mar 17, 2026
bad3c62
Merge branch 'main' into patch-4
willhoy Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions src/rmq/rmqa/rmqa_compressiontransformerimpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,17 +125,33 @@ rmqt::Result<> CompressionTransformerImpl::inverseTransform(
bsl::shared_ptr<bsl::vector<uint8_t> >& data,
rmqt::Properties& props)
{

BSLS_ASSERT(props.headers);
int64_t originalSize =
(*props.headers)["sdk.transform.compression.size"].the<int64_t>();

rmqt::FieldTable::const_iterator sizeIt =
props.headers->find("sdk.transform.compression.size");
if (sizeIt == props.headers->end() || !sizeIt->second.is<int64_t>()) {
BALL_LOG_ERROR << "Missing or invalid compression size header";
return rmqt::Result<>("Missing or invalid compression size header");
}

int64_t originalSize = sizeIt->second.the<int64_t>();

if (originalSize <= 0) {
BALL_LOG_ERROR << "Invalid original size for decompression: "
<< originalSize;
return rmqt::Result<>("Invalid original size for decompression: " +
bsl::to_string(originalSize));
}
bsl::string compressionAlg =
(*props.headers)["sdk.transform.compression.alg"].the<bsl::string>();

rmqt::FieldTable::const_iterator algIt =
props.headers->find("sdk.transform.compression.alg");
if (algIt == props.headers->end() || !algIt->second.is<bsl::string>()) {
BALL_LOG_ERROR << "Missing or invalid compression algorithm header";
return rmqt::Result<>(
"Missing or invalid compression algorithm header");
}
bsl::string compressionAlg = algIt->second.the<bsl::string>();

rmqt::Result<> result;
if (compressionAlg == "zstd") {
Expand Down
Loading