Skip to content

Fix missing is_same case for char #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
willhoy merged 1 commit into from
Jul 7, 2025
Merged

Fix missing is_same case for char #62

willhoy merged 1 commit into from
Jul 7, 2025

Conversation

@hallfox
Copy link
Contributor

@hallfox hallfox commented Jul 1, 2025

Problem statement

char is a distinct type from unsigned char and `signed char, even though this should be supported.

Proposed changes

Add an is_same check for char

Remaining work

  • Unit Tests
  • Integration Tests
  • Documentation

@hallfox
Fix missing is_same case for char
b4e21f9 
Signed-off-by: Taylor Foxhall <tfoxhall@bloomberg.net>
@hallfox hallfox force-pushed the fix-is-same-char branch from ce0bc3d to b4e21f9 Compare July 2, 2025 19:07
@willhoy willhoy merged commit 2271b23 into bloomberg:main Jul 7, 2025
5 checks passed
@hallfox hallfox deleted the fix-is-same-char branch July 25, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willhoy willhoy willhoy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hallfox @willhoy